ADF Desktop

  • Items to check for in a Code Review:
    • Member variables defined in Application Modules or VOs
    • Referencing VOs and AM directly in the UI (ADF Faces layer) code – this can lead to memory leaks and worse if references are held across requests
    • Check that all the managed beans that are defined in anything other than Request / BackingBean scope are correctly marked as serializable (and indeed are!)
    • Incorrect use of Component references (see here and here)
    • Accessing scopes by grabbing maps from ADFContext.getCurrent() (e.g. getViewScope()) this can have unexpected effects if the object you are looking for has not been created for.  Injection of beans is preferred and more robust
    • Any JavaScript use needs a careful look at, particularly with reference to consistent use of clientComponent=“true” and locating client side components by ID (see here)
    • Correct assignment of IDs to components in forEach (see here) – even though that causes most problems in 12c you should still do it correctly in 11g
    • Definition of popups within a stamping component like a table